-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(webSocket): fix node.js example #2441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use socket$
and Observable.webSocket
@@ -60,12 +60,11 @@ export class WebSocketSubject<T> extends AnonymousSubject<T> { | |||
* | |||
* import { w3cwebsocket } from 'websocket'; | |||
* | |||
* let socket = new WebSocketSubject({ | |||
* let subject = new WebSocketSubject({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think we should go with socket$
everywhere, and use Observable.webSocket
rather than new WebSocketSubject
.
I'm glad you caught this, though. Would you mind making this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Let me know if I should squash the commits, Edit: I just noticed that it does say to do so. I'll do in a minute. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description: Fixes the example showing the usage of
WebSocketSubject
on Node.js.Related issue (if exists): none